Lower case the string in a way that works with any language #11375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
the
not-in-changelog
mattab
changed the title
tsteur
reviewed
Feb 20, 2017
| @@ -54,8 +54,7 @@ public function __construct($idSite = false) | |||
| if ($segment['category'] == $visitTitle | |||
| && ($segment['type'] == 'metric' && $segment['segment'] != 'visitIp') | |||
| ) { | |||
| $metricsLabel = Piwik::translate('General_Metrics'); | |||
| $metricsLabel[0] = Common::mb_strtolower($metricsLabel[0]); | |||
| $metricsLabel = Common::mb_strtolower(Piwik::translate('General_Metrics')); | |||
There was a problem hiding this comment.
Is it on purpose to remove the metricsLabel[0] completely?
There was a problem hiding this comment.
Yes, this is the fix actually: it does not work to use [0] to replace first character in a multibyte chinese string since the first character might be 2 or 3 bytes.
There was a problem hiding this comment.
Sweet. You can call this a fix as well then to completely remove it :) 👍 Thought you meant to really fix it
There was a problem hiding this comment.
It's the real fix actually, we're now lowercasing the whole string which has the same effect of just lower casing the first letter (in most languages anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11130