New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package "mass icons" via composer or submodule #11370
Comments
Hi @Findus23
|
As mentioned I don't mind but currently I am not able to as I
Are you sure that (1) is necessary as it seems like Github doesn't include submodules in ZIP archives. (just empty directories) |
You should be able to do that nevertheless. Within your repo setting you should have possibility to "transfer ownership". That way you should be able to move it to piwik. |
Oddly it seems like this isn't possible
But I should be able to transfer it to you and then you can transfer it to piwik. |
Got a request for transfer, but can't accept it. Getting a 500 error when visiting the confirmation page. But you might add me as collaborator within your repo settings. Maybe I'm able to transfer it on my own. |
BTW: While we're on it, has anyone an idea for a better name? |
Nope. doesn't work either. Seems I can't enter the settings as collaborator. |
That would work |
Just created it. You should have admin access to this new repo https://github.com/piwik/device-icons |
EDIT: Forgot to accept invite |
Seems to be working |
Name: how about |
Sounds good (and descriptive) |
How about |
we could also add that within an plugin like |
I didn't think of the fact that icons will be loaded from the Web app UI. I thought that we would still copy all icons to the right places / in the right plugins folders ? |
Sue, if we copy them, it's not a problem. Not sure how it will be handled... |
I'm not sure if we should copy them as this creates many directories whose source isn't obvious. |
By copying I meant only copy those directories within But maybe that's not too useful and we could put all icons in the Morpheus theme. |
I agree |
Good point re: PHP, like a console command in the maybe not everybody would have to run this script, as it would only be run when some icons are updated or so, which would be not so frequent and likely done by just a few team members. |
Yes, but everyone (also travis) needs to run it once after git clone, otherwise they don't see any icons. |
we need those icons in the git repo without having to run any command, because it's expected that a fresh Piwik git clone will just work out of the box. So we'll have to add/push them to the repo as well. So far I see two options
|
If we add them to the git repository it gets much more complicated.
That way a git clone (with clone of sub directories "just work") and we only need to remove the source images on build. |
@Findus23 Your last proposal sounds good and best so far 👍 I think it would work nicely! |
New piwik-icons repository and project: https://github.com/piwik/piwik-icons 🎉 |
Currently I maintain all "mass icons" (browsers, os, flags, ...) in my repository https://github.com/Findus23/device-icons and create pull requests against the main piwik repository on changes.
I want to change this to directly using the repository as
While submodules would be easier for testing, it seems like they are only used for optional plugins in piwik. And it would add the whole repository (not just the resized images), but this could be solved in the build script.
On the other hand, it's possible to exclude all unneeded files from github zips (see https://github.com/Findus23/device-icons/archive/1.1.0.zip), which in theory should also exclude them from composer packages. (I haven't tested it)
What would you prefer?
(PS: In both cases it might be useful to move it to the piwik organisation)
The text was updated successfully, but these errors were encountered: