Fix UIControl memory leak #11362
Merged
Fix UIControl memory leak #11362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, every `UIControl` ever created would be stored in `UIControl._controls`. During cleanup, every `UIControl` would be checked to see if it is still active in the DOM, but would never be removed from the array. Now, cleanup only retains a reference to active `UIControl` instances. This change also decouples `UIControl` IDs from the length of the array.
sgiehl
reviewed
Mar 25, 2017
| @@ -67,6 +75,9 @@ | |||
| throw new Error("Error: " + control.constructor.name + "'s destroy method does not call " + | |||
| "UIControl.destroy. You may have a memory leak."); | |||
| } | |||
| } else { | |||
| // Control is still active / used. | |||
| activeControls.push(control); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Isn't here something missing like UIControl._controls = activeControls;, in order to keep track of those controls not removed by the current run of cleanupUnusedControls
There was a problem hiding this comment.
Nope.
var activeControls = UIControl._controls = []; sets both UIControl._controls and activeControls to the same new array instance.
activeControls.push modifies that same array instance.
There was a problem hiding this comment.
ah. yes. you're right. thanks for clarifying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every
UIControlever created would be stored inUIControl._controls. During cleanup, everyUIControlwould be checked to see if it is still active in the DOM, but would never be removed from the array.Now, cleanup only retains a reference to active
UIControlinstances. This change also decouplesUIControlIDs from the length of the array.