Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparent icons are hard to recognize on dark backgrounds #11352

Closed
Findus23 opened this issue Feb 18, 2017 · 5 comments
Closed

transparent icons are hard to recognize on dark backgrounds #11352

Findus23 opened this issue Feb 18, 2017 · 5 comments
Assignees
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.

Comments

@Findus23
Copy link
Member

Findus23 commented Feb 18, 2017

Follow-up to discussion in #11271

bildschirmfoto von 2017-01-24 09-36-38

I have now modified the script so that instead of replacing white with transparency it floodfills all white parts with transparency beginning from all four corners. That way white parts of icons (e.g. Quicktime, Windows Media) will stay white and the icons look great on light grey backgrounds.
While it improves many icons there are still some left, that are impossible to recognize on dark backgrounds (mostly because they are only made of dark lines)
bb
java
Because of that I would recommend adding a white background with CSS in these cases (mostly the black popup)

@mattab
Copy link
Member

mattab commented Feb 20, 2017

I have now modified the script so that instead of replacing white with transparency it floodfills all white parts with transparency beginning from all four corners. That way white parts of icons (e.g. Quicktime, Windows Media) will stay white and the icons look great on light grey backgrounds.

This sounds ideal! Glad you could make this work.

Because of that I would recommend adding a white background with CSS in these cases (mostly the black popup)

👍

@mattab mattab added this to the Priority Backlog (Help wanted) milestone Feb 20, 2017
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Feb 20, 2017
@Findus23
Copy link
Member Author

I have now added a new release on https://github.com/Findus23/device-icons. Should I create a new pull request or wait until we have found a solution for Findus23/device-icons? (e.g. use as a composer package similar to piwik/searchengine-and-social-list)

@mattab
Copy link
Member

mattab commented Feb 20, 2017

@Findus23 shall we create new issue regarding finding a solution to package icons in Piwik core via composer or submodule etc. ?

If we can find a solution quickly then maybe it's worth waiting to push the new icons to KISS

@Findus23
Copy link
Member Author

@Findus23 shall we create new issue regarding finding a solution to package icons in Piwik core via composer or submodule etc. ?

see #11370

@Findus23
Copy link
Member Author

Findus23 commented Apr 7, 2017

This should have greatly improved with matomo-org/matomo-icons@1161949

screenshot_20170407_132426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

No branches or pull requests

2 participants