Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking code - comment // should be /* */ #11332

Closed
iiegn opened this issue Feb 10, 2017 · 0 comments
Closed

tracking code - comment // should be /* */ #11332

iiegn opened this issue Feb 10, 2017 · 0 comments
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
3.0.2

Comments

@iiegn
Copy link
Contributor

iiegn commented Feb 10, 2017

#10797 introduced a comment in the tracking code
// tracker methods like "setCustomDimension" should be called before "trackPageView"
this should be
/* tracker methods like "setCustomDimension" should be called before "trackPageView" */
to make it possible to use html/js minimizer tools: making one line out of the current tracking code snippet ruines the code.
@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Feb 11, 2017
@iiegn iiegn mentioned this issue Feb 18, 2017
Merged
mattab pushed a commit that referenced this issue Feb 18, 2017
@iiegn @mattab
Fix #11332 (#11333)
5b8619f 
Change '//' comment to '/* ... */' to avoid interference with html/js optimisers.
@mattab mattab added this to the 3.0.2 milestone Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
3.0.2
Development

No branches or pull requests
3 participants
@tsteur @mattab @iiegn