Fix Piwik UI becomes very slow when having many rows #11308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
c: Design / UI
|
Code looks ok. But there's one thing we could improve. When showing exact 250 entries in an action datatable the row actions are already disabled while the other hover effects are visible. This is caused by https://github.com/piwik/piwik/blob/3.x-dev/plugins/Actions/javascripts/actionsDataTable.js#L60 |
|
Great catch. Changed the number to 255, I presume this would fix the problem? |
|
yep, that fixes the problem as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce eg go to Actions => Pages for Month, then select flatten and "all" in the limit. If you now see like 700-2000 rows or so Piwik UI will take seconds to render and it will be almost impossible to scroll. Doing some profiling I was able to improve it a little by disabling some features when there are > 250 rows. Ideally we would make those features simply faster (if possible) and enable it for all rows but for now it will be better to disable those features and have at least a usable UI
Performance could be still improved but would need to spend more time.