Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Smartbanners #11301

Merged
merged 4 commits into from Feb 19, 2017
Merged

Remove Smartbanners #11301

merged 4 commits into from Feb 19, 2017

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Jan 30, 2017

refs #4520 and #201
In my opinion the banner is quite ugly and outdated:
bildschirmfoto vom 2017-01-30 15-11-18
In addition it isn't maintained any more: https://github.com/jasny/jquery.smartbanner

But the library isn't needed:
iOS will show a system banner if <meta name="apple-itunes-app" content="app-id=737216887" /> is added (which already is): https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/PromotingAppswithAppBanners/PromotingAppswithAppBanners.html

And Chrome on Android is supporting a similar banner by adding the following to the manifest.json:

  "prefer_related_applications": true,
  "related_applications": [
    {
      "platform": "play",
      "id": "org.piwik.mobile2"
    }
  ]

https://developers.google.com/web/updates/2015/03/increasing-engagement-with-app-install-banners-in-chrome-for-android?hl=en#native (scroll down to Native app install banner)

Only difference: They are only shown on HTTPS and if "The user has visited your site twice over two separate days during the course of two weeks"

@mattab mattab added this to the 3.0.2 milestone Feb 18, 2017
@mattab
Copy link
Member

mattab commented Feb 18, 2017

Thanks for the PR @Findus23 👍 we'll review this for 3.0.2

@mattab mattab merged commit 0e16aae into matomo-org:3.x-dev Feb 19, 2017
@Findus23 Findus23 deleted the remove-smartbanners branch February 19, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants