Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Check widget disappeared from admin homepage in 3.0.1-b3 #11299

Closed
mattab opened this issue Jan 30, 2017 · 1 comment
Closed

System Check widget disappeared from admin homepage in 3.0.1-b3 #11299

mattab opened this issue Jan 30, 2017 · 1 comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.0.2

Comments

@mattab
Copy link
Member

mattab commented Jan 30, 2017

Probably regressed /buggy change in #11288

regression visible in UI tests
@mattab mattab added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jan 30, 2017
@mattab mattab added this to the 3.0.2 milestone Jan 30, 2017
@sgiehl
Copy link
Member

sgiehl commented Jan 30, 2017

Yes it is: See d38c804#diff-ba052faba7db018ae5ee1f72ffdbc950
The second parameter of $widgetsList->isDefined needs to be the action, not the name

mattab added a commit that referenced this issue Feb 13, 2017
@mattab
Fixes #11299
1d8501a
@mattab mattab closed this as completed in 5eb911a Feb 13, 2017
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.0.2
Development

No branches or pull requests
2 participants
@mattab @sgiehl