Ecommerce Life Time Value metrics + New Ecommerce section in Visitor Profile #11294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ new fields returned in Live APIs: ecommerceLifeTimeValue, ecommerceLifeTimeOrdersCount
…nstead of just last 100 visits
tsteur
reviewed
Jan 30, 2017
| COALESCE(SUM(" . LogAggregator::getSqlRevenue('items') . "), 0) as lifeTimeEcommerceItems | ||
| FROM " . Common::prefixTable('log_visit') . " AS log_visit | ||
| LEFT JOIN " . Common::prefixTable('log_visit') . " AS log_visit_visitors | ||
| ON (log_visit.idsite = log_visit_visitors.idsite AND log_visit.idvisitor = log_visit_visitors.idvisitor) |
There was a problem hiding this comment.
wouldn't we safe one join when matching by idvisitor directly? do we not have the idVisitor in Live API?
tsteur
reviewed
Jan 30, 2017
| private function getSqlEcommerceConversionsLifeTimeMetricsForIdGoal($ecommerceIdGoal) | ||
| { | ||
| $sql = "SELECT | ||
| COALESCE(SUM(" . LogAggregator::getSqlRevenue('revenue') . "), 0) as lifeTimeRevenue, |
There was a problem hiding this comment.
Wondering why we need COALESCE ?
There was a problem hiding this comment.
SUM returns NULL when there are not matching rows (ie. no ecommerce conversions)
There was a problem hiding this comment.
sure, usually just doing it in PHP as usually better readable
Merged
Closed
mattab
added
the
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Ecommerce metrics shown in the Visitor Profile now apply to "Life time" (before they used to apply to last 100 visits only).
Need to fix system test before merging
Fixes #2750