Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define icon size for plugin icon in popup in visitor log #11271

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Findus23
Copy link
Member

Another place where the icon size is not defined:
bildschirmfoto von 2017-01-23 22-05-14

Unfortunately this shows a mistake I made when generating the new icons:
I replaced the white background with transparency to replicate the look of the old icons. But this also replaced white parts of the logos, which isn't visible normally but looks ugly on non-white backgrounds:
bildschirmfoto von 2017-01-24 09-36-38

To fix it I would need to regenerate all icons and replace them either with non-transparent ones or use floodfill from one corner (which may create new issues if the background is not one connected background.

Of course there is also the "hack" of adding background: white; to the icons.

@mattab mattab modified the milestone: 3.0.2 Jan 30, 2017
@mattab
Copy link
Member

mattab commented Feb 18, 2017

@Findus23

Thanks for the PR! 👍

Unfortunately this shows a mistake I made when generating the new icons:
I replaced the white background with transparency to replicate the look of the old icons. But this also replaced white parts of the logos, which isn't visible normally but looks ugly on non-white backgrounds:

Oh, nice find, and this is a tricky one! Maybe you could create a new issue to discuss this challenge. It seems there is no easy or clear solution. It was really useful to have transparent icons when displaying icons on a grey / light grey background such as visitor log.

To fix it I would need to regenerate all icons and replace them either with non-transparent ones or use floodfill from one corner (which may create new issues if the background is not one connected background.

I'm not sure, but first intuition would be to make transparent the background "around" the icons, ie. in the outside part of each icons, while leaving in White color any pixels inside the icon itself (inside the drawings). Not sure if it's do-able or if it would be correct to do this though?

@mattab mattab merged commit fd88377 into matomo-org:3.x-dev Feb 18, 2017
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Feb 18, 2017
@Findus23 Findus23 deleted the fix-visitor-log-popup-icon-size branch February 18, 2017 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants