Implements new SMS Provider ASPSMS.com #11263
Conversation
sgiehl
added
not-in-changelog
sgiehl
added
Needs Review
| { | ||
| $this->getCreditLeft($apiKey); | ||
| return array( |
There was a problem hiding this comment.
Can we move this as default to SMS Provider base class? Then we likely wont break other plugins like http://plugins.piwik.org/FreeMobileMessaging
There was a problem hiding this comment.
good point. Will change that.
sgiehl
force-pushed
the
aspsms
branch
2 times, most recently
from
b4bb146
to
1b9ec5c
Compare
|
Feedback:
|
|
Hm. that used to work. I'll have a look |
Caused by the session already closed before, as it's done using a ajax request calling a Session:start() reopens the session. Might be a bit hackish, but should be fine for development
…f throwing uncatched exception
|
@mattab should hopefully be fixed now :) |
|
Works. We now have a new SMS Provider, awesome! |
|
Feedback to apply @sgiehl
|
| * A new SMS provider for sms reports has been added: [ASPSMS.com](http://www.aspsms.com/en/?REF=227830) | ||
|
|
||
| ### Breaking Changes | ||
| * SMS provider now need to define their credential fields by overwriting `getCredentialFields()`. This allows to have SMS providers that require more than only an API key. |
There was a problem hiding this comment.
Is this still a breaking change? Or did we make it backwards compatible? Would be really great to keep BC and if not release 3.1. But ideally I would really want to not break BC in 3.X in general when it is possible to keep BC
There was a problem hiding this comment.
good point. I'll change that. It's not breaking BC anymore
fixes #11213