Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-1.0: use production server default for error messages #1124

Closed
anonymous-matomo-user opened this issue Jan 22, 2010 · 5 comments
Closed
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@anonymous-matomo-user
Copy link

By default PHP error messages and printDebug() output are displayed to all users accessing the admin or widgets. This can provide server information to malicious users. A new option should be added to config.ini.php to disable all error output to the browser. Additionally it would be useful to set this option separately for admin and non-admin users.

Currently the only way to disable printDebug() is by setting

$GLOBALS['PIWIK_TRACKER_DEBUG'] = false

Instead of adding a new config value, another option would be to default PIWIK_TRACKER_DEBUG to false and only set it to true if an admin is logged in.

By default PHP error output is enabled with the display_errors option. The default should be to suppress PHP error output and only enable it for admin users.

@robocoder
Copy link
Contributor

Since we're in development mode, I've deferred this request to post-1.0.

In the meantime, you can add that one-liner to a bootstrap.php file in your root piwik folder (which isn't overwritten by an update).

@mattab
Copy link
Member

mattab commented Mar 21, 2010

I can't think of an expected use case where Piwik would throw errors and this wouldn't be a bug. In all cases, errors should not be thrown but should be caught and properly handled. Closing as won't fix. If such error show up, please create a ticket and we will ensure that they are handled with a human readable error message, or don't make the Piwik UI or tracking fail.

@pattonwebz
Copy link

Is there no way for me to mark these recent updates as spam?

@sgiehl
Copy link
Member

sgiehl commented Apr 29, 2014

I've removed that spam...

@pattonwebz
Copy link

Replying to SteveG:

I've removed that spam...
Awesome :)

@anonymous-matomo-user anonymous-matomo-user added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

5 participants