Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/*/API.php - E_STRICT cleanup #1122

Closed
robocoder opened this issue Jan 22, 2010 · 6 comments
Closed

plugins/*/API.php - E_STRICT cleanup #1122

robocoder opened this issue Jan 22, 2010 · 6 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

For consistency (and to avoid E_STRICT warnings), public API functions should be declared as "static public". In many cases, it's simply "public" (or in some cases, implied).

Use of $this should be replaced with self::getInstance().

@robocoder
Copy link
Contributor Author

(In [1817]) fixes #1122

@robocoder
Copy link
Contributor Author

(In [1832]) fixes #1122 - per Matt's review

@robocoder
Copy link
Contributor Author

(In [1833]) refs #1122 - fix usage

@robocoder
Copy link
Contributor Author

(In [1834]) refs #1122 - fix core usage

@robocoder
Copy link
Contributor Author

(In [1835]) refs #1122 - fix unit test

@mattab
Copy link
Member

mattab commented Feb 11, 2010

Tu summarize, instead of changing all API methods to being static, we decided to change all callers to not call methods statically as this could cause various issues in the future. Thanks vipsoft!

@robocoder robocoder added this to the Piwik 0.5.5 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants