@sgiehl opened this Pull Request on October 1st 2013 Member

As we are trying to get rid of all the Zend parts we are using, I've changed the ExampleRssWidget which was still using Zend_Feed. It now uses simplexml instead.

Any thoughts or suggestions?

@halfdan commented on October 1st 2013 Member

I like the change! Will it however still be able to parse RSS and Atom feeds?

I'll have to adjust my FeedAnnotation plugin (see referenced ticket) since it uses Zend_Feed.

@sgiehl commented on October 1st 2013 Member

atom feeds have another structure than rss. so you might need to use other properties within the xml. Maybe we could also use another smaller and simpler script for that...

@mattab commented on October 2nd 2013 Member

It's a good change because the example plugin is more simple and does not require Zend_Feed...

@halfdan instead of rewriting FeedAnnotations, maybe you could simply bundle Zend_Feed in your plugin so you can keep supporting Atom feeds?

@mattab commented on October 2nd 2013 Member

@sgiehl please merge the PR if you have tested it and are happy with it! :+1:

@halfdan commented on October 2nd 2013 Member

@mattab I don't want Zend_* anywhere near my plugin. The dependency is way too big to bundle it with my plugin. I'm going to write my own simple feed parser.

This Pull Request was closed on October 2nd 2013
Powered by GitHub Issue Mirror