changed ExampleRssWidget to use simplexml instead of Zend_Feed #112
Conversation
… is unused now and can be removed
|
I like the change! Will it however still be able to parse RSS and Atom feeds? I'll have to adjust my FeedAnnotation plugin (see referenced ticket) since it uses Zend_Feed. |
|
atom feeds have another structure than rss. so you might need to use other properties within the xml. Maybe we could also use another smaller and simpler script for that... |
|
It's a good change because the example plugin is more simple and does not require Zend_Feed... @halfdan instead of rewriting FeedAnnotations, maybe you could simply bundle Zend_Feed in your plugin so you can keep supporting Atom feeds? |
|
@sgiehl please merge the PR if you have tested it and are happy with it! 👍 |
changed ExampleRssWidget to use simplexml instead of Zend_Feed
|
@mattab I don't want Zend_* anywhere near my plugin. The dependency is way too big to bundle it with my plugin. I'm going to write my own simple feed parser. |
As we are trying to get rid of all the Zend parts we are using, I've changed the ExampleRssWidget which was still using Zend_Feed. It now uses simplexml instead.
Any thoughts or suggestions?