Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtime Log - Specific icons for each Windows Version #11173

Open
github-hbr opened this issue Jan 10, 2017 · 7 comments
Open

Realtime Log - Specific icons for each Windows Version #11173

github-hbr opened this issue Jan 10, 2017 · 7 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.

Comments

@github-hbr
Copy link

all windows versions (7, 8.1, 10) displayed with the same picture now.
in 2.1x different pictures for different windows versions used.

@Findus23
Copy link
Member

Are you sure that there were different icons in 2.x? I think all (desktop) Windows versions used the following icon: https://github.com/piwik/piwik/blob/2.x-dev/plugins/DevicesDetection/images/os/WIN.gif

But I agree with you that it would be better if every Windows version would show its own logo.

@sgiehl is there any reason that all versions are mapped to "WIN"?
https://github.com/piwik/piwik/blob/2.x-dev/plugins/DevicesDetection/functions.php#L254-L266

@github-hbr
Copy link
Author

github-hbr commented Jan 10, 2017

the icon you linked was for winxp in piwik2.1x (if i guess right..)
it is not that one that is diplayed here in piwik3.x for win xp, 7, 8.1, 10
the icon displayed here for win xp, 7, 8.1, 10 in piwik3.x is that one:
https://github.com/piwik/piwik/blob/3.x-dev/plugins/DevicesDetection/images/os/WIN.png

@Findus23
Copy link
Member

@github-hbr If I remember correctly there was and still is only one icon for all windows versions. I just changed it from the old xp-like logo to the new WIN10 logo.
But it may be nice if every Windows version would have its own logo.

@sgiehl
Copy link
Member

sgiehl commented Jan 23, 2017

We used to have special detection for Windows in device detector. Each Windows had been reported as its "own" os. As that was not really correct (os is always Windows and version is XP, 10, 7 and so on), it has been changed in device detector and in Piwik. All windows versions are showing the same icon in Piwik 3.

@Findus23
Copy link
Member

Maybe it's possible to use a different logo for the versions and fallback to the current logos if there is no version specific logo.
https://github.com/piwik/piwik/blob/3.x-dev/plugins/DevicesDetection/functions.php#L283

I'll look into it, if I have time.

@sgiehl
Copy link
Member

sgiehl commented Jan 23, 2017 via email

@Findus23
Copy link
Member

I'm afraid there is no easy way to get the version.
If anyone has a solution I'll contribute the icons.

@mattab mattab changed the title Realtime Log - Picture Windows Version Realtime Log - Specific icons for each Windows Version Feb 20, 2017
@mattab mattab added this to the Backlog (Help wanted) milestone Feb 20, 2017
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

No branches or pull requests

4 participants