New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realtime Log - Specific icons for each Windows Version #11173
Comments
Are you sure that there were different icons in 2.x? I think all (desktop) Windows versions used the following icon: https://github.com/piwik/piwik/blob/2.x-dev/plugins/DevicesDetection/images/os/WIN.gif But I agree with you that it would be better if every Windows version would show its own logo. @sgiehl is there any reason that all versions are mapped to "WIN"? |
the icon you linked was for winxp in piwik2.1x (if i guess right..) |
@github-hbr If I remember correctly there was and still is only one icon for all windows versions. I just changed it from the old xp-like logo to the new WIN10 logo. |
We used to have special detection for Windows in device detector. Each Windows had been reported as its "own" os. As that was not really correct (os is always Windows and version is XP, 10, 7 and so on), it has been changed in device detector and in Piwik. All windows versions are showing the same icon in Piwik 3. |
Maybe it's possible to use a different logo for the versions and fallback to the current logos if there is no version specific logo. I'll look into it, if I have time. |
The short code, used in that method, doesn't point to the version and it
might be tricky to get it in. But feel free to give it a try 👍
|
I'm afraid there is no easy way to get the version. |
all windows versions (7, 8.1, 10) displayed with the same picture now.
in 2.1x different pictures for different windows versions used.
The text was updated successfully, but these errors were encountered: