Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve icons and images in piwik #11155

Closed
Findus23 opened this issue Jan 7, 2017 · 12 comments · Fixed by #11601
Closed

Improve icons and images in piwik #11155

Findus23 opened this issue Jan 7, 2017 · 12 comments · Fixed by #11601
Assignees
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Milestone

Comments

@Findus23
Copy link
Member

Findus23 commented Jan 7, 2017

Follow-up to #10587 and similar to #9292

There are still many low resolution icons left in piwik:

  • Flags:

    • Personally I don't like the "glossy" look of the current flags. (e.g fr)
    • There are many libraries providing official flags as svg (mostly from wikipedia | e.g lipis/flag-icon-css)
    • After some tries I realized that converting the svg to 16px png images isn't enough.
      While some simple flags look better (in my opinion, like at, fr or ch) others get ugly as too much detail is lost. (pk, us, sz, ba)
    • I'm not sure what to do as it is pretty hard to show many details in 192 Pixel total (16x12)
      This got better by increasing the icon size to 64x48px: ,,,
    • I would suggest keeping the height at 16px (48px) even if this means being a bit wider than the other icons, as they would fit better in line.
    • old vs. new
  • DevicesDetection/images/screens

    • In my opinion it's quite important to replace these (11) icons, as they are extremely pixelated next to the new icons
      6083834a-d13a-11e6-9ffb-38dd847ed4ad
    • Anybody got an idea what icons to use. I haven't found pretty ones.
  • DevicesDetection/images/brand

But there are still many single icons left (either in Morpheus or in the images folders of the core plugins). Best would be to recreate them a vector image and maybe even embed them as svg.

@Findus23
Copy link
Member Author

Findus23 commented Jan 10, 2017

Some ideas for images/screens:

@Findus23
Copy link
Member Author

Findus23 commented Feb 2, 2017

For most of them there are fitting material icons: https://material.io/icons/
Now I'm just missing "phablet", "portable media player" and "smart display".
Any ideas how to visualize them?

@mattab
Copy link
Member

mattab commented Feb 20, 2017

  • Smart display: could we reuse the TV icon?
  • phablet: could we reuse tablet icon?
  • portable media player: maybe reuse smartphone?

@sgiehl do you think these three device categories still make sense? or would we consider removing them in the future...?

@sgiehl
Copy link
Member

sgiehl commented Feb 20, 2017

good question. They will stay in device detector for now. But we might combine the numbers in Piwik reports. Not sure how useful it is for users to see those device types.

@mattab
Copy link
Member

mattab commented Feb 20, 2017

we might combine the numbers in Piwik reports.

👍

@mattab mattab added this to the 3.0.3 milestone Feb 20, 2017
@mattab mattab added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Feb 20, 2017
@mattab
Copy link
Member

mattab commented Mar 25, 2017

Hi @Findus23 what's the status on this issue? (maybe we could create smaller separate issues for any remaining icons to be improved)

@Findus23
Copy link
Member Author

Findus23 commented Mar 25, 2017

Flags: #11272
screens: If the current pull requests are merged and everything is working, I'll start working on it (which should be pretty fast)
Brand Icons: I am still missing an easy solution and the time to manually collect the icons.
If anyone wants to create a pull request to the piwik-icon repo with source images, I'd do the rest.

@mattab mattab modified the milestones: 3.0.4, 3.0.3 Mar 28, 2017
@Studio384
Copy link

Studio384 commented Mar 28, 2017

There is also some need to take a second look at the Internet Explorer icons, both for desktop and Mobile. The desktop icon isn't the official one and the IE for Windows Phone icon is out of the context that particular variation is supposed to be used in. The white-on-colored-background icon isn't supposed to be used in the context Piwik uses it, it is only for tiles and tile-like instances. Just go with the flat blue-on-white icon there.

This is the correct Internet Explorer icon: https://github.com/alrra/browser-logos/blob/master/src/archive/internet-explorer_9-11/internet-explorer_9-11.png. Notice how it is lighter.
This is the correct Internet Explorer Mobile icon: https://upload.wikimedia.org/wikipedia/commons/2/2f/Internet_Explorer_10_logo.svg. Notice that it doesn't have a background.

@Findus23
Copy link
Member Author

@Studio384 We have now created a repository for the icons: https://github.com/piwik/piwik-icons
You can report all issues there.

About Deskop IE: Are you sure? When in doubt I tend to trust Wikipedia more. But maybe its a good idea to replace it with the latest Logo:
https://commons.wikimedia.org/wiki/File:Internet_Explorer_10_logo.svg
This one is used in https://en.wikipedia.org/wiki/Internet_Explorer

About Windows Phone: You are right that the tile is looking a bit odd. But if we use the "normal" logo you can't distinguish it with the desktop one.

@Studio384
Copy link

No, the logo you're linking is only used in the "About" page, anywhere else throughout Windows and Internet Explorer the normal full colored logo is used. The logo that is being used in Piwik right now is however not that logo but instead a darker altered version.

The version Wikipedia uses should represent IE Mobile in Piwik, and with that we also have a clear distinction between desktop and Mobile.

@Findus23
Copy link
Member Author

Findus23 commented Apr 3, 2017

@Studio384 BTW, with matomo-org/matomo-icons#7 I am using the lighter IE-logo. While I am still not sure if it's correct, I am trusting you and alrra to know it better than me. (I'm not using windows)

@Studio384
Copy link

Well, have a look then at the logo Windows uses:
capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants