New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting API: apply hideColumns
recursively to nested values by setting hideColumnsRecursively=1
#11115
Conversation
18bbb4c
to
f71b4b0
Compare
6f0d24b
to
4203fce
Compare
That be actually a very big (breaking) change. Are we sure we'd want to do this and are we clear on all that it means for all the different API calls? I'm not sure I'd want this merged actually and rather close it I would say. |
@tsteur what about having an additional option for those filters to filter recursively? could maybe also be exposed as api parameter or something like that? |
@sgiehl that could work. Although generally not seeing that feature request very often and then we need to add test cases and support it etc. Generally that would work though 👍 |
maybe @mattab can say something about the intention of that PR? Not sure what it would be needed for 🤔 |
The goal of the PR was to be able to filter columns in the output of the Live APIs, where currently showColumns/hideColumns aren't applied, and all data is always returned for all visitors. it was requested a few times over the years to be able to remove/show only some columns in these Live API outputs, as they are wordy/large by default. |
If it's easy to do we can introduce one additional general API parameter to enable this behaviour but we would not want this by default. |
Another idea: could we otherwise only offer this specific behavior (by default) to Live APIs only? because it's only useful for Live APIs afaik so not really needed to add this feature to our API as a whole maybe... |
9f1de85
to
f059e63
Compare
f059e63
to
63be778
Compare
@sgiehl can you add one system test for the Live API? |
63be778
to
7d4abe8
Compare
added a test |
hideColumns
recursively to nested values by setting hideColumnsRecursively=1
No description provided.