@halfdan opened this Pull Request on September 29th 2013 Member

This pull request removed Zend_Registry from core by replacing it with an own simplistic Registry implementation in core/Registry.php.

I didn't yet comment the code in core/Registry, but will do so once merged.

Suggestions/Feedback?

@halfdan commented on September 29th 2013 Member

Hm. That test failure is interesting. It shouldn't happen.

@mattab commented on September 30th 2013 Member

Nice change... Build failed maybe because you removed the file 2.0-a7.php ?

@sgiehl commented on September 30th 2013 Member

Guess there is an 'use Piwik\Registry' missing in FrontController.php

@halfdan commented on September 30th 2013 Member

Good catch, but sadly not the reason for test failure. For some reason the with entry in the registry vanishes.

@halfdan commented on September 30th 2013 Member

Auth entry that is

@halfdan commented on September 30th 2013 Member

Fixed.

This Pull Request was closed on September 30th 2013
Powered by GitHub Issue Mirror