Removing Zend_Registry from Core #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: core/ErrorHandler.php core/ExceptionHandler.php core/FrontController.php core/Log.php core/Piwik.php
|
Hm. That test failure is interesting. It shouldn't happen. |
|
Nice change... Build failed maybe because you removed the file 2.0-a7.php ? |
|
Guess there is an 'use Piwik\Registry' missing in FrontController.php |
|
Good catch, but sadly not the reason for test failure. For some reason the with entry in the registry vanishes. |
|
Auth entry that is |
|
Fixed. |
halfdan
added a commit
that referenced
this pull request
Sep 30, 2013
Removing Zend_Registry from Core fixes #4188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removed Zend_Registry from core by replacing it with an own simplistic Registry implementation in core/Registry.php.
I didn't yet comment the code in core/Registry, but will do so once merged.
Suggestions/Feedback?