Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Minor angular update from 1.4.10 to 1.4.14" #11099

Merged
merged 1 commit into from Dec 27, 2016

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 27, 2016

Some integration tests started failing so reverting #11021

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 27, 2016
@mattab mattab added this to the 3.0.1 milestone Dec 27, 2016
@mattab mattab merged commit 7dc4f49 into 3.x-dev Dec 27, 2016
@tsteur
Copy link
Member

tsteur commented Dec 27, 2016

Are you sure the failing tests were because of this change?

@tsteur
Copy link
Member

tsteur commented Dec 27, 2016

I see you mean integration tests. If it is re whitespace thing we could have just fixed that

@mattab
Copy link
Member Author

mattab commented Dec 27, 2016

Yes could have fixed it but was un-sure if I wouldn't make it worse. Feel free to revert the revert 👍

@mattab mattab deleted the revert-11021-angular1414 branch December 27, 2016 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants