Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated searchEngine and social icons #11093

Merged
merged 6 commits into from Jan 5, 2017

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Dec 26, 2016

Follow-up to #11063: (related to #10587, #9292 and matomo-org/searchengine-and-social-list#28)
I have crawled all URLs from the searchengine-and-social-list and added

  • the favicon defined via <link rel="shortcut icon" href="/absolute/or/relative/link" />
  • or the first icon defined via <link rel="icon" href="/absolute/or/relative/link" />
  • or the favicon served at /favicon.ico

If the .ico contains multiple sizes, the largest is extracted.
Finally, all images are converted to png.

To preserve historical data, I haven't deleted images of sites that aren't online any more.

Work in progress as I haven't checked all of them. (GitHub unfortunately shows only 25 visual diffs)

@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Dec 26, 2016
@sgiehl
Copy link
Member

sgiehl commented Dec 27, 2016

Note: We do not need images for all urls in the definition files. There is only one needed for each search engine / social network. The file name needs to have the url first listed in the search engine / social definition (regardless from which url you are able to pull it).

@mattab mattab modified the milestone: 3.0.1 Dec 27, 2016
@Findus23
Copy link
Member Author

I forgot to comment, but I have removed the unnecessary images and sharpened them as mentioned in #11063 (comment).

@Findus23
Copy link
Member Author

Findus23 commented Jan 3, 2017

The large icons in the tables should be resolved with this change in the first pull request:
37b3ab0#diff-8b20fa1b843d28bf8988e7c3c93a54b2R483

@mattab
Copy link
Member

mattab commented Jan 3, 2017

Looks awesome @Findus23 - is the PR now ready to merge do you think?

@Findus23 Findus23 changed the title [WIP] updated searchEngine and social icons updated searchEngine and social icons Jan 4, 2017
@sgiehl
Copy link
Member

sgiehl commented Jan 5, 2017

This PR is ready? Just noticed the icons have different sizes. But guess that is the maximum size you could grab for each, correct?

@Findus23
Copy link
Member Author

Findus23 commented Jan 5, 2017

Exactly, most people use 16x16px as a favicon, but some had higher resolution icons, which I used.

@sgiehl sgiehl changed the base branch from 3.x-dev to better-icons January 5, 2017 10:34
@sgiehl sgiehl removed the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jan 5, 2017
@sgiehl sgiehl merged commit 6315cb9 into matomo-org:better-icons Jan 5, 2017
@sgiehl sgiehl mentioned this pull request Jan 5, 2017
sgiehl added a commit that referenced this pull request Jan 5, 2017
* updated browser and os icons (#11063)

* updated browser-icons

from https://github.com/Findus23/device-icons
72d5ffef94a597c4ba226b33344e0badaadc3c35

* added os icons

* added previous icons

* changed macOS icon

* replaced optipng with pngquant (36% size reduction)

* center icons vertically

* sharpen icons

* increased icon size to 48x48

* fixed visitorPopup and realtimemap

* revert css change

* fixed HTML-Reports

* replaced Windows icon

#11063 (comment)

* max-width and max-height for datatables

* removed submodul (sorry wrong commit)

* add explicit max-size for dataTableRowActions

* fixed UNK.png

* first try at fixing system tests

* fixed cookie.gif

* updates icons in System tests

* updated plugin icons (#11121)

* updated plugin icons

* increased icon size to 48x48

* updated searchEngine and social icons (#11093)

* updated and added searchEngine and social icons

* removed unnecessary icons

* sharpen icons

* increased icon size to 48x48

* fixed promovideo socialicons

http://builds-artifacts.piwik.org/piwik/piwik/3.x-dev/21859/UIIntegrationTest_dashboard1.png

* fixed xx.png

* updates plugin icons in system tests

* [tests] RockMelt has it's own icon

* updates expected UI test files

* submodule update

* fix some last tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants