Enabling WOFF files under Windows IIS #11091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! I had seen these reports and didn't realise we could fix this problem in Piwik. Awesome!
Ideally all methods except createFilesForSecurity should be protected and we'd always have to call createFilesForSecurity (for simplicity) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After upgrading to Piwik 3 on Windows IIS, I encountered a 404 error on the icon file (/plugins/Morpheus/fonts/piwik.woff) because the type for WOFF files (application/font-woff) isn't included by default in the IIS server configuration (similar issues has been reported previously on IIS (#5255) but also on Apache (#8691, #9967)).
To fix this, I suggest to add the appropriate mime type in the IIS configuration file.
(Off-topic) By the way, in the ServerFilesGenerator class, why the createWebConfigFiles method is protected whereas the deleteWebConfigFiles and createHtAccessFiles (and others) methods are public ? This seems inconsistent and forces me to use the createFilesForSecurity method, which will also recreate the Apache files.