Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to disable LOAD DATA LOCAL INFILE when open_basedir restrictions and/or safe_mode are enabled #11088

Open
KaanErturk opened this issue Dec 26, 2016 · 6 comments
Open

No need to disable LOAD DATA LOCAL INFILE when open_basedir restrictions and/or safe_mode are enabled #11088

KaanErturk opened this issue Dec 26, 2016 · 6 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Backlog (Help wan...

Comments

@KaanErturk
Copy link

When you use a remote MySQL server and can't get FILE privilege, i.e. AWS RDS, you need LOAD DATA LOCAL INFILE capability. For some reason that was an issue in PHP when open_basedir or safe_mode were enabled and their workaround was to just disable it. However it's been fixed since last year, for PHP version 5.6.17 and above and when mysqlnd is used. See the fix here: php/php-src@be6fd4b

There is a similar workaround in Piwik codebase (see https://github.com/piwik/piwik/blob/9243b9a7b6fae8237596f76cda1fe8b6816463af/core/Db/BatchInsert.php#L193). I think that should be removed, perhaps conditionally for PHP 5.6.17+.

open_basedir and safe_mode are not the ultimate security measures but still, it would be good to enable them and have Security and System Check pages on Piwik all-green as well as LOAD DATA LOCAL INFILE working as it should.
@KaanErturk
Copy link
Author

This is related to #10732 and #7519 btw.

@mattab
Copy link
Member

mattab commented Dec 26, 2016

@KaanErturk Sounds good to make the code in https://github.com/piwik/piwik/blob/9243b9a7b6fae8237596f76cda1fe8b6816463af/core/Db/BatchInsert.php#L193 conditional to PHP 5.6.17+. Did you check it works with safe mode and/or open basedir?
Pull request welcome 👍

@mattab
Copy link
Member

mattab commented Feb 20, 2017

Hi @KaanErturk any chance you could create a Pull request for this issue? Would be very appreciated!

@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Feb 20, 2017
@mattab mattab added this to the Backlog (Help wanted) milestone Feb 20, 2017
@djosip
Copy link

djosip commented Nov 2, 2017

It has been over a year since KaanErturk wrote his comment about this issue and I can see that the problem with open_basedir and LOAD DATA LOCAL INFILE still persists.
Is there any hope that piwik might finally change its behavior as per KaanErtuk's suggestion?

@rick-pri
Copy link

rick-pri commented Feb 10, 2020 •
edited

I can see that there was an attempt to rectify this issue here 93a363c

However, if safe_mode is on this will disable INFILE_LOCAL. I'm not sure that this should be the case. Anyway, I still get the message about this. I eventually found the issue. Basically I had to set mysqli.allow_local_infile = On in my php.ini file. I found this by accident, I found that the PDO driver was working and then I found this setting and setting it in my php.ini fixed the issue. (I mention this as it would be worth putting into the documentation page on this issue, as I gave up on this last September and have only just come back to revisit it.)

Next up is pecl geoip 2 ...

@tsteur
Copy link
Member

tsteur commented Feb 10, 2020

Thanks @rick-pri added this to https://matomo.org/faq/troubleshooting/#faq_194 seeing here this was disabled by default a while ago: https://www.php.net/manual/en/mysqli.configuration.php

Will also create a new issue to eventually try enable this automatically

@tsteur tsteur mentioned this issue Feb 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
5 participants
@KaanErturk @tsteur @mattab @rick-pri @djosip