Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make interaction_position and visit_total_interactions MEDIUMINT to prevent Numeric value out of range: 1264 Out of range value for column interaction_position / visit_total_interactions #11086

Merged
merged 2 commits into from Jan 20, 2020

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 26, 2016

fixes #11058 correctly

For existing installations, these two fields must be manually updated to MEDIUMINT (because we are not allowed to make huge schema changes in a minor version)

@mattab mattab added this to the 3.0.1 milestone Dec 26, 2016
@mattab mattab changed the title Make interaction_position MEDIUMINT to prevent Numeric value out of range: 1264 Out of range value for column interaction_position / visit_total_interactions Make interaction_position and visit_total_interactions MEDIUMINT to prevent Numeric value out of range: 1264 Out of range value for column interaction_position / visit_total_interactions Dec 26, 2016
@mattab
Copy link
Member Author

mattab commented Dec 26, 2016

Actually this PR will also cause any existing Piwik install to trigger a slow schema upgrade when upgrading to 3.0.1! Not sure if we should merge it as it would trigger a slow DB migration

@mattab
Copy link
Member Author

mattab commented Dec 26, 2016

Alternative would be:

  • do a min(value, 32767) in the tracker API to prevent mysql out of range issues
  • move this PR to PIwik 4.0

@jloh
Copy link

jloh commented Nov 15, 2017

I've run into this issue on a Piwik 3.1.x install and ran the fix described in #11722. This has however left my install slightly broken and not recording all visits from log_import.py. I posted a question on the forum however no one has replied. Is there a known fix/way to get the results into my install again?

…ange: 1264 Out of range value for column 'interaction_position'

fixes #11058
…of range: 1264 Out of range value for column 'visit_total_interactions'
@sgiehl
Copy link
Member

sgiehl commented Jan 17, 2020

rebased the branch and resolved the conflicts, guess it should be good to merge now

@tsteur tsteur merged commit 6b3273c into 4.x-dev Jan 20, 2020
@tsteur tsteur deleted the mediumint_position branch January 20, 2020 21:08
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB Fields to small (again :( )
4 participants