When safe mode is displayed, and Super User was not logged in already, let Super User display the full safe mode to troubleshoot further #11082
Conversation
…, let Super User display the full safe mode to troubleshoot further
Feature looks like this for Anonymous users / non super users
|
… css compiling, display the safe mode
when there's an error during Twig template processing, or during LESS css compiling, display the safe mode
… forwarding the i_am_super_user URL parameter
mattab
added
c: Usability
|
Merging now before a code review because will be nice to have in a beta. Feedback welcome and i'll happily apply code review feedback later 👍 |
| * Need to catch that PHP7 error object on php5 | ||
| */ | ||
| if( !class_exists('\Error')) { | ||
| class Error { |
There was a problem hiding this comment.
Hopefully it's the right way to define the PHP7 Error object in PHP5
| echo $this->generateSafeModeOutputFromException($e); | ||
| exit; | ||
| } catch(\Error $e) { | ||
| echo $this->generateSafeModeOutputFromException($e); |
There was a problem hiding this comment.
Here we're catching errors such as: #10876 Call to undefined method Piwik\Menu\MenuTop::add() which should be displayed safe mode instead of a not-so-useful error page
| @@ -133,6 +148,15 @@ public function dispatch($module = null, $action = null, $parameters = null) | |||
| * @param \Piwik\NoAccessException $exception The exception that was caught. | |||
| */ | |||
| Piwik::postEvent('User.isNotAuthorized', array($exception), $pending = true); | |||
| } catch (\Twig_Error_Runtime $e) { | |||
| echo $this->generateSafeModeOutputFromException($e); | |||
There was a problem hiding this comment.
Here we're catching the case of #10738 An exception has been thrown during the rendering of a template (".form-description is undefined: failed at .form-description; line: 6182") in "@CoreUpdater/runUpdaterAndExit_welcome.twig" at line 8.
| $this->pluginManager->deactivatePlugin($pluginName); | ||
| $this->redirectAfterModification($redirectAfter); | ||
| if($this->isAllowedToTroubleshootAsSuperUser()) { | ||
| Piwik::doAsSuperUser(function() use ($redirectAfter) { |
There was a problem hiding this comment.
as a result of this code, anyone who knows the secret salt of a Piwik instance may be able to deactivate plugins, as long as they also know the Nonce so it should be very safe
If you don't know which plugin is causing this error, we recommend to first disable any plugin not created by "Piwik" and not created by "InnoCraft".)