Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core:archive command: fix comment to match implementation #11079

Closed
wants to merge 1 commit into from
Closed

core:archive command: fix comment to match implementation #11079

wants to merge 1 commit into from

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 25, 2016 •
edited

Noticed this issue while investigating #11027

@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Dec 25, 2016
@mattab mattab added this to the 3.0.1 milestone Dec 25, 2016
@mattab mattab mentioned this pull request Dec 25, 2016
Closed
@sgiehl
Copy link
Member

sgiehl commented Dec 27, 2016

I don't think that change is needed - looking at the implementation of hadWebsiteTrafficSinceMidnightInTimezone (https://github.com/piwik/piwik/blob/64351d08e3cbb85564cac2b0c2eaef96a7a6804f/core/CronArchive.php#L1176-L1195).

But there should already be a logger entry with the correct "since info"

@mattab mattab closed this Dec 27, 2016
@mattab mattab deleted the comment_match_implementation branch January 2, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattab @sgiehl