Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behind proxy no Internet: impossible to view the Administration > Plugins page #11065

Closed
ThaDafinser opened this issue Dec 22, 2016 · 5 comments
Closed

Behind proxy no Internet: impossible to view the Administration > Plugins page #11065

ThaDafinser opened this issue Dec 22, 2016 · 5 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
Backlog (Help wan...

Comments

@ThaDafinser
Copy link
Contributor

My config:
[General]
enable_auto_update = 0
enable_update_communication = 0

But this does not cover 2 calls for plugins (Update + paid)

Workaround for now:

namespace Piwik\Plugins\Marketplace\Api;


class Client
{
    private function fetch($action, $params)
    {
        return false;
@tsteur
Copy link
Member

tsteur commented Dec 22, 2016

Do you mean it still does execute calls to the Marketplace even when it is disabled? Another workaround would be to disable the Marketplace plugin. I just had a look at the description and those configs are actually not meant to "not do any requests" afaik.

@ThaDafinser
Copy link
Contributor Author

ThaDafinser commented Dec 23, 2016 •
edited

@tsteur out of the box the marketplace plugin is enabled.

So if you have a server with no internet connection, you can't even browse to the plugin page due to timeouts...so a normal user won't be able to disable the plugin.
2nd a normal users won't find out that this plugin is causing that issue.

my suggestion: make a timeout at 5s, if it reaches that: display a notification with a message like
"It seems there is no connection to the marketplace, please check your internet conneciton and/or....
If you cannot establish a connection, click here to disable the Marketplace plugin

@mattab
Copy link
Member

mattab commented Dec 26, 2016

I just had a look at the description and those configs are actually not meant to "not do any requests" afaik.

FYI we have this issue opened to at some point create a new config setting to disable all http requests: #6324

@mattab mattab changed the title Behind proxy: Plugin checks break admin GUI Behind proxy no Internet: impossible to view the Administration > Plugins page Feb 20, 2017
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Feb 20, 2017
@mattab mattab added this to the Priority Backlog (Help wanted) milestone Feb 20, 2017
@mattab
Copy link
Member

mattab commented Feb 20, 2017

my suggestion: make a timeout at 5s, if it reaches that: display a notification with a message like "It seems there is no connection to the marketplace, please check your internet conneciton and/or....If you cannot establish a connection, click here to disable the Marketplace plugin "

Thanks for the suggestion @ThaDafinser - a pull request would be very appreciated !

@sgiehl sgiehl mentioned this issue May 30, 2017
Merged
@mattab
Copy link
Member

mattab commented Sep 4, 2018

This was added in 3.6.0: What features use the Internet and what to white-list for Matomo notifications/auto update to work, and how to completely disable internet

@mattab mattab closed this as completed Sep 4, 2018
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @mattab @ThaDafinser