Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Update also deactivated plugins #11044

Closed
hpvd opened this issue Dec 19, 2016 · 6 comments
Closed

Auto-Update also deactivated plugins #11044

hpvd opened this issue Dec 19, 2016 · 6 comments
Labels
worksforme The issue cannot be reproduced and things work as intended.

Comments

@hpvd
Copy link

hpvd commented Dec 19, 2016

Auto-Update also deactivated plugins
because of 3 reason:

  1. I'm note sure, if this time, there is an easy way to make a deactivated plugin active again when Piwik version got incompatible (because of Piwik update) during plugin was deactivated?
    (see what happens in this case error message trying to activate incompatible plugin on P3.0: very general #11041)
  2. reduce number of problems when trying to activate a plugin (e.g. compatibility, bugs):
    when having always the latest one installed, this should be the best available one.
  3. maybe even deactivated plugins may influence security in some cases
@mattab
Copy link
Member

mattab commented Dec 25, 2016

@hpvd do you know if we currently check for new updates for deactivated plugins? we definitely should, I guess.

@hpvd
Copy link
Author

hpvd commented Dec 26, 2016

I think Piwik doesn't check and doesn't update deactivated plugins -that's why I opened this issues...
(but as always I didn't check the code if it shouldn't do)
btw: merry x-mas!

@hpvd
Copy link
Author

hpvd commented Jan 9, 2017

imho this is pretty important and one should not push this to the far future... (see the 3 reasons above)
What do you think?

@tsteur
Copy link
Member

tsteur commented Jan 9, 2017

AFAIK and I had a rough look in the code we do check for all plugins here: https://github.com/piwik/piwik/blob/3.0.0/plugins/Marketplace/Plugins.php#L167-L169 This should include deactivated ones.

@hpvd
Copy link
Author

hpvd commented Jan 9, 2017

Many thanks for looking in the code!

I just had a deeper look too:
You are right! It's no general problem.
Most are updated but not all.

e.g. in my installation AOM plugin is installed, but deactivated and it's not updated.
Noticed that there are several new versions by looking at it's github page.

Looking in Piwik's integrated Marketplace, I couldn't even find it anymore.
("huu... was it banned for some reason?")
Looking for it on https://plugins.piwik.org directly I managed to find it.
("hmm, why is there a difference to internal view?")

When looking into it's details I realized that it has requirements Piwik <3.0.0b1

So there is simply no compatibility version for Piwik 3.

=> With this we need a better handling not for deactivated,
but for deactivated and not compatible anymore plugins.

some ideas:

  • should one update them even if latest version is not compatible to current piwik version (e.g. for security reason)?
  • do not show "activate"-Link in list of installed plugins if not compatible to current version
  • show a hint instead "not compatible to current piwik version"
  • do not make them disappear in internal marketplace view, make it transparent and show "not compatible for your piwik version"
  • add a filter for plugin search "not compatible"/"other piwik versions" (so one can still find the plugin and ask the author for an update...)

@mattab
Copy link
Member

mattab commented Feb 18, 2017

So it should already more or less work. AOM wasn't updated because there was no 3.0 compatible release at the time. Closing this issue @hpvd but feel free to open separate requests for your suggestions / the ones you think are most important.

@mattab mattab closed this as completed Feb 18, 2017
@mattab mattab added the worksforme The issue cannot be reproduced and things work as intended. label Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants