Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe mode: Display plugin versions next to plugin names #11043

Closed
hpvd opened this issue Dec 19, 2016 · 2 comments
Closed

Safe mode: Display plugin versions next to plugin names #11043

hpvd opened this issue Dec 19, 2016 · 2 comments
Assignees
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone

Comments

@hpvd
Copy link

hpvd commented Dec 19, 2016

Make Error Message

A fatal error occurred
The following error just broke Piwik (v3.0.0)

even more helpful

by showing version number of plugins installed -in addition to their names

=> with this one could more easy search (google) for a possible solution ...

learned from:
#11041

2016-12-19_10h51_13

@hpvd hpvd changed the title Make Error Message even more helpful Make Error Message "fatal error" even more helpful Dec 19, 2016
@mattab mattab changed the title Make Error Message "fatal error" even more helpful Safe mode: Display plugin versions next to plugin names Dec 25, 2016
@mattab mattab added this to the Backlog (Help wanted) milestone Dec 25, 2016
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Dec 25, 2016
@mattab mattab modified the milestones: 3.0.1, Backlog (Help wanted) Dec 26, 2016
@mattab
Copy link
Member

mattab commented Dec 26, 2016

Plugin version added in safe mode in https://github.com/piwik/piwik/pull/11082/files

@mattab mattab self-assigned this Dec 26, 2016
@mattab
Copy link
Member

mattab commented Dec 27, 2016

Done in #11082

@mattab mattab closed this as completed Dec 27, 2016
mattab added a commit that referenced this issue Dec 27, 2016
…, let Super User display the full safe mode to troubleshoot further (#11082)

* When safe mode is displayed, and Super User was not logged in already, let Super User display the full safe mode to troubleshoot further

* meant for a different PR

* Catch exceptions during CSS/Less compiling

* when there's an error during Twig template processing, or during LESS css compiling, display the safe mode

* Deactivate plugin as super user when authenticated with i_am_super_user

* when user is not logged as Super User, Make deactivate plugin work by forwarding the i_am_super_user URL parameter

* Display plugin version in safe mode fixes #11043

* Added a text to indicate users to first disable third party plugins

* Updated UI test

* clarify that salt is a secret

* reuse helper method

* minor

* Catching PHP7 errors and making it work on php5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

No branches or pull requests

2 participants