Fix API reference page is partly broken #11033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # js/piwik.js # js/piwik.min.js # piwik.js
mattab
added
the
not-in-changelog
tsteur
reviewed
Dec 18, 2016
| * @return string | ||
| */ | ||
| public function getAllInterfaceString($outputExampleUrls = true, $prefixUrls = '') | ||
| public function getAllInterfaceString($outputExampleUrls = true, $prefixUrls = '', $displayTitlesAsAngularDirective = true) |
There was a problem hiding this comment.
It would be better to either have a separate method for this, OR to rename it to something like "embedded or widgetized" and not that specific that will break over time and be misused over time. Ideally it was a separate method though or we would include angular wherever it is embedded.
There was a problem hiding this comment.
Instead of calling the API directly maybe it could be built a widget maybe? not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In http://developer.piwik.org/api-reference/reporting-api
the titles
Module XYZare missing because in Piwik 3 we use an angular js directive to display titles.in this PR we restore the previous behavior for the
listAllMethodscontroller action (called to generate our API ref doc in https://github.com/piwik/developer-documentation/blame/master/docs/3.x/reporting-api.md#L204-L206 )