Dimension columns default null #11032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piwik 3.0.0-b3 release
Piwik 3.0.0-b4 release
Release Piwik 3.0.0-beta5
Release Piwik 3.0.0-rc1
3.0.0-rc2 release
Piwik 3.0.0-rc3 release
Piwik 3.0.0-rc4 release
Piwik 3.0.0-rc4 release
|
Sorry about that, it was fixed in #10492 . Usually we fix all related issues but rarely we may forget or do not find all of the related issues. Really appreciate your work there though. Thanks for this 👍 I will close the issue now. Looking forward to your next PR. Merry Christmas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6207. There were only a few dimensions that did not allow NULL values (
$ ack 'columnType\s*=.*NOT NULL').It looks like there are some migrations to be done, I am looking in to that now.Oh neat, migration was actually handled automatically.