@spacenate opened this Pull Request on December 18th 2016 Contributor

Refs #6207. There were only a few dimensions that did not allow NULL values ($ ack 'columnType\s*=.*NOT NULL').

It looks like there are some migrations to be done, I am looking in to that now. Oh neat, migration was actually handled automatically.

@tsteur commented on December 18th 2016 Owner

They are not null on purpose as they are required by Piwik in order to function properly. I'm pretty sure https://github.com/piwik/piwik/issues/6207 was actually fixed just recently and most dimensions apart from these were set to null. Did you create this PR because you saw the issue #6207 or did you have a specific problem?

@spacenate commented on December 18th 2016 Contributor

The former - I was looking through issues attached to the 3.0.0 milestone, and found #6207. I did find it curious how few dimensions did not allow null 😛 If #6207 is all set, feel free to close this PR.

@tsteur commented on December 19th 2016 Owner

Sorry about that, it was fixed in https://github.com/piwik/piwik/pull/10492 . Usually we fix all related issues but rarely we may forget or do not find all of the related issues.

Really appreciate your work there though. Thanks for this :+1:

I will close the issue now. Looking forward to your next PR. Merry Christmas

This Pull Request was closed on December 19th 2016
Powered by GitHub Issue Mirror