Remove json2 from piwikjs #11031
Closed
Remove json2 from piwikjs #11031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piwik 3.0.0-b3 release
Piwik 3.0.0-b4 release
Release Piwik 3.0.0-beta5
Release Piwik 3.0.0-rc1
3.0.0-rc2 release
Piwik 3.0.0-rc3 release
Piwik 3.0.0-rc4 release
Piwik 3.0.0-rc4 release
|
We are still supporting IE7 and IE6 when it comes to tracking as well as some other old browsers. We could remove JSON3, however we would need to announce it in advance and give people time to work around. For example we would need to give people the possibility to include |
|
Ah okay - I was confused by the 3.0.0 milestone on #6093.
What would you like me to do with this PR? |
oops, we need to take another look at all issues in this milestone. we hope you'll pick another issue to work on 👍 thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6093, removes the JSON3 library from piwik.js. More specifically, I removed the global
JSON_PIWIK, and replaced all references to it withwindowAlias.JSON. I also updated the Incompatibility table comment at the top of the file. I then minified this file as described in js/README.md.