Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ #11028

Closed
ghost opened this issue Dec 17, 2016 · 18 comments
Closed

_ #11028

ghost opened this issue Dec 17, 2016 · 18 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@ghost
Copy link

ghost commented Dec 17, 2016

_

@Findus23
Copy link
Member

Is it possible that this is the same issue as #10738?
Do you use the InterSites plugin?

@tsteur
Copy link
Member

tsteur commented Dec 18, 2016

Can you go to Administration => Plugins. Then select the filter "Third-party" and let us know which ones are enabled?

It cannot really be triggered by TreemapVisualization but is likely a different plugin

@mattab
Copy link
Member

mattab commented Dec 18, 2016

can you paste here the content of config.ini.php below the [Plugins] section?

Ideally we'd like to trigger our "safe mode" when this occurs, so that you can easily disable the plugin

@mattab mattab added this to the 3.0.0-rc milestone Dec 18, 2016
@sgiehl
Copy link
Member

sgiehl commented Dec 18, 2016

Maybe ClickHeat causes the problem. As far as I have seen that plugin is not yet compatible with Piwik 3

@tsteur
Copy link
Member

tsteur commented Dec 18, 2016

It seems to not override the topbar event, neither does WebsiteGroups. Probably one of the others

@tsteur
Copy link
Member

tsteur commented Dec 18, 2016

Actually InterSites is installed according to that list. Marking it as duplicate

@tsteur tsteur closed this as completed Dec 18, 2016
@tsteur tsteur added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 18, 2016
@sgiehl
Copy link
Member

sgiehl commented Dec 18, 2016

Did you also remove that plugin from filesystem?

@tsteur tsteur reopened this Dec 18, 2016
@sgiehl
Copy link
Member

sgiehl commented Dec 18, 2016

No it isn't (See http://plugins.piwik.org/InterSites). Try removing it from file system.

@mattab
Copy link
Member

mattab commented Dec 18, 2016

Piwik 3 is ready and will be released today.

Changing time periods works for us. See it: http://demo.piwik.org/

@mattab
Copy link
Member

mattab commented Dec 18, 2016

there is no easy way to downgrade to 2.x

@mattab
Copy link
Member

mattab commented Dec 18, 2016

@stehlo

  • go to Settings > Plugins and update all plugins that can be updated
  • go to Marketplace > Third party. Which third party plugins are listed here?
  • Disable one by one the third party plugins (not those created by "piwik" since they should work), until you find that the JS error is gone

Which plugin was causing the JS error?

@sgiehl
Copy link
Member

sgiehl commented Dec 18, 2016

You might also try to clean the tmp directory of Piwik.

@mattab
Copy link
Member

mattab commented Dec 18, 2016

Go to Marketplace > Third party. Which third party plugins are listed here?

Then, you can try to disable these plugins one by one, until you find that your Piwik date range/calendar is working well again as expected

@sgiehl
Copy link
Member

sgiehl commented Dec 18, 2016

You might add the following to your config.ini.php:

[Development]
enabled = 1
disable_merged_assets = 1

This enables development mode and disables the merged assets. That way all javascript files will be loaded separately. That should help to exactly trace down where the error occurs.

mattab added a commit that referenced this issue Dec 18, 2016
@mattab
Copy link
Member

mattab commented Dec 18, 2016

@stehlo can you please try to apply this patch: 0e3cf32

and then delete your piwik/tmp/ folder and try again?

@mattab
Copy link
Member

mattab commented Dec 18, 2016

Thanks @stehlo for the quick feedback! it's good to know we caught this issue just before release 👍

@mattab
Copy link
Member

mattab commented Dec 18, 2016

as we'd like to find the root cause, do you know in which widget this error appeared? how could we reproduce this error? do you find a way now to reproduce it on demo.piwik.org (still running rc4) ?

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed duplicate For issues that already existed in our issue tracker and were reported previously. labels Dec 18, 2016
mattab added a commit that referenced this issue Dec 19, 2016
#11035)

* refs #11023 better piwik.js json compatibility

* fix some tests

* fix json lint tests

* Display titles correctly in API reference doc

* Slightly better code

* Prevent error reported in #11028

* Per Thomas feedback

* fix
@mattab
Copy link
Member

mattab commented Dec 19, 2016

fixed in #11035

@mattab mattab closed this as completed Dec 19, 2016
@ghost ghost changed the title Error when upgrading from 2.x to 3.0.0-rc4 _ Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

No branches or pull requests

4 participants