Expose JSON property for Piwik custom trackers #11025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI tests fail in https://travis-ci.org/piwik/piwik/jobs/184434598 |
|
was already fixed when I added tests |
mattab
added
the
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be good to expose the JSON Piwik uses in the
Piwikobject. This allows plugins to usePiwik.JSONso they don't have to use hard coded egJSON2.This would be great to have in Piwik 3 final release as it makes sure tracker plugins will have a working JSON even when Piwik changes it's JSON usage eg in #11024 to
JSON_PIWIK.It can't break anything so it should be an easy merge