Store site search settings correctly #11022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Needs Review
sgiehl
commented
Dec 15, 2016
| @@ -226,7 +226,7 @@ public function setValue($value) | |||
| $value = call_user_func($config->transform, $value, $this); | |||
| } | |||
|
|
|||
| if (isset($this->type)) { | |||
| if (isset($this->type) && !is_null($value)) { | |||
There was a problem hiding this comment.
This is needed as otherwise null values would be casted to 0 or empty string
sgiehl
commented
Dec 15, 2016
| return null;// never actually save a value for this | ||
| $field->transform = function ($value) use ($settings) { | ||
| if ($value) { | ||
| $settings->unsetSiteSearchKeywords = true; |
There was a problem hiding this comment.
Needed to do that using a class property, as setting a value for the other setting would be directly overwritten afterwards.
|
Seems not working for me. reproduce:
|
|
Hope that works now as expected. Please check again |
…xsitesearchsetting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10971