Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piwik should not reload page when applying a segment #11012

Closed
tsteur opened this issue Dec 14, 2016 · 1 comment · Fixed by #11013
Closed

Piwik should not reload page when applying a segment #11012

tsteur opened this issue Dec 14, 2016 · 1 comment · Fixed by #11013
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
3.0.0-rc

Comments

@tsteur
Copy link
Member

tsteur commented Dec 14, 2016

This should not reload the page as it is slow etc.
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Dec 14, 2016
@tsteur tsteur added this to the 3.0.0-rc milestone Dec 14, 2016
@mattab mattab mentioned this issue Dec 14, 2016
Closed
@mattab
Copy link
Member

mattab commented Dec 14, 2016

fyi This was regressed in: https://github.com/piwik/piwik/pull/10969/files
because with the patch:

  • When editing a segment and clicking "save" then when re-editing again this segment, attributes such as "Available to all users" are not restored
  • Newly created Segments appear in the segment list with creator 'undefined' in the Tooltip text, instead of displaying the username

@tsteur tsteur mentioned this issue Dec 14, 2016
Merged
@mattab mattab changed the title Piwik reloads page when applying a segment Piwik should not reload page when applying a segment Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
3.0.0-rc
Development

Successfully merging a pull request may close this issue.

Piwik should not reload page when applying a segment matomo-org/matomo
2 participants
@tsteur @mattab