Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix different hints where to put tracking code on website #11011

Merged
merged 2 commits into from Dec 14, 2016
Merged

Fix different hints where to put tracking code on website #11011

merged 2 commits into from Dec 14, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 14, 2016

fixes #11007

I'm not quite sure what was meant before with "footer" file. Renamed it to "head tag"

@tsteur tsteur added the Needs Review PRs that need a code review label Dec 14, 2016
@tsteur tsteur added this to the 3.0.0-rc milestone Dec 14, 2016
@tsteur tsteur mentioned this pull request Dec 14, 2016
Closed
@mattab mattab merged commit 1e572c9 into 3.x-dev Dec 14, 2016
@mattab mattab deleted the 11007 branch December 14, 2016 22:56
@tsteur
Copy link
Member Author

tsteur commented Dec 14, 2016

What does "header file" mean?

@mattab
Copy link
Member

mattab commented Dec 14, 2016

it refers to most CMS / websites implementing the practise of having a header file and a footer file for easy modification across sites. I think the "footer file" is more famous/well-known but most people would understand header file as well, right?

@tsteur
Copy link
Member Author

tsteur commented Dec 14, 2016

I don't think most people would understand what is meant by it. Maybe something would be better like "added to the &lgt;head>" tag which is often defined in a "header.php", "header.tpl" or "header.twig" template file.

@mattab
Copy link
Member

mattab commented Dec 15, 2016

@tsteur Good point, done in 6442f14

mattab added a commit that referenced this pull request Dec 15, 2016
@mattab
Updated instruction for JS code in #11011 #11007
3c61f12
mattab added a commit that referenced this pull request Dec 16, 2016
@mattab
Updated instruction for JS code in #11011 #11007
24641ff
mattab pushed a commit that referenced this pull request Dec 16, 2016
@sgiehl @mattab
Store site search settings correctly (#11022)
a2c17ae 
* store site search settings correctly

* Updated instruction for JS code in #11011 #11007

* improve check if default keywords are used

* Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.0-rc
Development

Successfully merging this pull request may close these issues.

different hints where to put tracking code on website
2 participants
@tsteur @mattab