New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.0-rc2 release #10994
Merged
3.0.0-rc2 release #10994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI tests for Piwik 3.x
See Funnels plugin where the first part is a block quote
Now that the type was changed to int, we no longer need that check
This is because angular might cancel the url change or listen to it themselves and not reload the page entirely.
… created Background: In Piwik 2.13 we removed the `Site.setSite` event because it is slow. So in some cases it may not actually trigger a `Sites.setSites` event when a site is loaded. For example when doing `new Site()`. I think in this case we should still trigger that event if the site did not exist yet because we do not call it very often and not in a loop for all sites etc. This is useful since `new Site` is used eg in `Controller` and for such cases we should trigger this event.
Make sure to trigger Sites.getSites event when a new Site instance is created
* Show support tab in marketplace plugins directly on the right with the other metadata * remove changelog tab and show it as a link
…e other metadata (#10977)
…all types (#10991) * Fix website measurable type was defining settings and properties for all types The settings specified in website measurable type should not apply to any other type by default. * add possibility to extend website settings * fix comparison was wrong * fix comparison was wrong * trying to fix the tests * fix test * tweak code * add test to make sure validation works with any type * add possibility to update group via settings
Fix flattener regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0-rc2 release