Use gender-neutral wording where possible #10982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@x3ro Looks good! Thanks for the PR. Some tests are failing because report documentation changed, but don't worry we can also update them afterwards. Is this finished or do you find more cases in the UI? Could you maybe try also in our submodules that may contain such strings. our submodules are init with |
|
Looks like the work is not finished: "they visits" |
mattab
reviewed
Dec 26, 2016
| @@ -62,11 +62,11 @@ | |||
| "ColumnNbActions": "Actions", | |||
| "ColumnNbActionsDocumentation": "The number of actions performed by your visitors. Actions can be page views, internal site searches, downloads or outlinks.", | |||
| "ColumnNbUniqVisitors": "Unique visitors", | |||
| "ColumnNbUniqVisitorsDocumentation": "The number of unduplicated visitors coming to your website. Every user is only counted once, even if he visits the website multiple times a day.", | |||
| "ColumnNbUniqVisitorsDocumentation": "The number of unduplicated visitors coming to your website. Every user is only counted once, even if they visits the website multiple times a day.", | |||
| "ColumnNbUsers": "Users", | ||
| "ColumnNbUsersDocumentation": "The number of users logged in your website. It is the number of unique active users that have a User ID set (via the Tracking code function 'setUserId').", | ||
| "ColumnNbVisits": "Visits", | ||
| "ColumnNbVisitsDocumentation": "If a visitor comes to your website for the first time or if he visits a page more than 30 minutes after his last page view, this will be recorded as a new visit.", | ||
| "ColumnNbVisitsDocumentation": "If a visitor comes to your website for the first time or if they visits a page more than 30 minutes after their last page view, this will be recorded as a new visit.", |
|
Whoops, thanks. Fixed now. |
|
Thanks @x3ro for this PR! If you like to contribute to other parts of Piwik please check out our Priority Backlog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR draft to tackle #10753. I essentially scanned through
git grep -iE "[^a-z](his/he/she/her)[^a-z]"to see what was change-worthy, and used "singular they" to remove the gender-specificity. Let me know if this is what you were aiming at @mattab, or if I missed something obvious.