Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix propagateNewPage might not actually load the page #10979

Merged
merged 1 commit into from Dec 9, 2016
Merged

Fix propagateNewPage might not actually load the page #10979

merged 1 commit into from Dec 9, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 7, 2016 •
edited

This is because angular might cancel the url change or listen to it themselves and not reload the page entirely.

@tsteur
Fix propagateNewPage might not actually load the page
8e0923f 
This is because angular might cancel the url change or listen to it themselves and not reload the page entirely.
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 7, 2016
@tsteur tsteur added this to the 3.0.0-rc milestone Dec 7, 2016
@tsteur tsteur merged commit 9227a3a into 3.x-dev Dec 9, 2016
@tsteur tsteur deleted the propagateNewPagefix branch December 9, 2016 06:34
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.0-rc
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @mattab