Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When adding / editing / deleting a segment in the UI, do not reload the whole page afterwards #10972

Closed
mattab opened this issue Dec 6, 2016 · 1 comment
Closed

When adding / editing / deleting a segment in the UI, do not reload the whole page afterwards #10972

mattab opened this issue Dec 6, 2016 · 1 comment
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
3.0.0-rc

Comments

@mattab
Copy link
Member

mattab commented Dec 6, 2016

it would be greater user experience if the whole UI didn't have to refresh when we create or edit or delete a custom segment. Ideally we would revert https://github.com/piwik/piwik/pull/10969/files while while fixing the few identified issues:

  • When editing a segment and clicking "save" then when re-editing again this segment, attributes such as "Available to all users" are not restored
  • Newly created Segments appear in the segment list with creator 'undefined' in the Tooltip text, instead of displaying the username
@mattab mattab modified the milestones: 3.0.0-rc, 3.0.0 Dec 6, 2016
@mattab mattab added c: Performance For when we could improve the performance / speed of Matomo. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Dec 6, 2016
@mattab mattab modified the milestones: 3.0.0-rc, 3.0.0 Dec 6, 2016
@mattab mattab mentioned this issue Dec 6, 2016
Merged
@mattab
Copy link
Member Author

mattab commented Dec 14, 2016

Actually we firstly need to fix the smaller-scope (and more important) issue of Applying segments should not reload the whole page; #11012

marking as duplicate

@mattab mattab closed this as completed Dec 14, 2016
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
3.0.0-rc
Development

No branches or pull requests
1 participant
@mattab