@mattab opened this Pull Request on December 6th 2016 Owner

the refresh is currently needed for not only this one bug, but other bugs as well. The Segmentation editor JS was not implemented in a modern way and segment listing is buggy without the page reload after a change to segments.

Later sometime we'll rewrite the Segment Editor in AngularJS later so this reload will not be needed and the segment editor will be responsive and easy to use on mobile.

fixes https://github.com/piwik/piwik/issues/10626
Reverting https://github.com/piwik/piwik/commit/5daf6c2388693746f2a47a9e6c31276d0b423a4f
part of https://github.com/piwik/piwik/commit/0c9c30b731ccbacf47e154b9f7a590af49e3d799

@tsteur commented on December 6th 2016 Owner

I wouldn't say anything if it was only when adding or deleting, but this is also when switching a segment and this hugely decreases the usability and performance etc.

@mattab commented on December 6th 2016 Owner

Yes definitely agree... will try to work on this later today https://github.com/piwik/piwik/issues/10972

This Pull Request was closed on December 6th 2016
Powered by GitHub Issue Mirror