Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0b4: Visitorlog show visit out of selcted date range #10949

Open
hpvd opened this issue Dec 3, 2016 · 6 comments
Open

3.0b4: Visitorlog show visit out of selcted date range #10949

hpvd opened this issue Dec 3, 2016 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@hpvd
Copy link

hpvd commented Dec 3, 2016

Just saw a visit in visitorlog from outside of selceted date range
Was first look in the morning and date-range was "day": maybe it has something to do with some kind of auto set date to today...
please see attachment.
2016-12-03_07h51_57

@tsteur
Copy link
Member

tsteur commented Dec 3, 2016

Is your website in the same timezone? At what time in your timezone did you request the data? (and which timezone is your website in?)

@hpvd
Copy link
Author

hpvd commented Dec 4, 2016

timezone of website is Europe/Berlin. Piwik and website run on same server.
Request was around 7:45 in the morning.

@tsteur
Copy link
Member

tsteur commented Dec 4, 2016

Was the browser maybe open over night? Meaning, before viewing that page, did you completely reload the page or open it directly?

@tsteur
Copy link
Member

tsteur commented Dec 7, 2016

I just had a similar problem before. I noticed when Piwik thinks it is viewing today then the log will only show >= timeStart but not >=timeStart,<=timeEnd and in my case there were already some visits logged "in the future". My case might be a bit different but related code is here: https://github.com/piwik/piwik/blob/3.0.0-b5/plugins/Live/Model.php#L495 Maybe the timezone is not correctly applied when checking Date::factory($dateString)->toString('Y-m-d') != Date::factory('now', $currentTimezone)->toString(). I have seen code parts where we needed to do instead Date::factory($dateString)->setTimezone($timezone)->toString('Y-m-d') instead of Date::factory($dateString, $timezone)->toString('Y-m-d').

Also I think in the first Date::factory($dateString)->toString('Y-m-d') the timezone is missing.

@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Dec 15, 2016
@mattab mattab added this to the 3.0.0 milestone Dec 15, 2016
@hpvd
Copy link
Author

hpvd commented Mar 28, 2017

still there in 3.03b1
same visit is shown on different dates (27.03. and 28.03 (today))

2017-03-28_14h24_55

@MatomoForumNotifications

This issue has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/top-date-widget-seems-to-take-server-time-instead-of-browser-location-time/50366/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants