Fix a bug where Piwik returns wrong rows by label #10947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
commented
Dec 3, 2016
| } | ||
|
|
||
| $table->setRows(array($rows[2], $rows[3], $rows[4])); | ||
| $table->rebuildIndex();// rebuildindex would be called anyway but we force rebuilding the index just to make sure |
There was a problem hiding this comment.
without the fix the rows index by label index would have looked like this
array (
'abc' => 0,
'def' => 1,
'ghi' => 0,
'jkl' => 1,
'mno' => 2,
),
|
That's an excellent & tricky find 🎱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just spent a couple of hours remote debugging a bug that I couldn't reproduce. Imaging you limit a data table and remove some rows.
Later you call
$table->getRowFromLabel('foobar');then it might still have the id mapped in$this->rowsIndexByLabeleven though the actual column was removed. Ideally, when a row is deleted, we would also delete the map from$this->rowsIndexByLabeldirectly. Naturally you would think a$table->setLabelsHaveChanged()would fix this but I noticed it does actually not unset all previously stored links so under circumstances$table->getRowFromLabel('foobar');might actually return a row with a completely different label. This is especially problematic when eg trying to rename something likeArchiver::LABEL_NOT_DEFINED. In this case a completely different row was renamed to "Not defined"This could actually explain a couple of odd issues and may be worth merging into Piwik 2 as well.