Fix a bug in query builder where tables are sorted randomly #10942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
commented
Dec 2, 2016
|
|
||
| if ($tA === $tB) { | ||
| return 1; // if both join same table keep order | ||
| } |
There was a problem hiding this comment.
Maybe even better would be to look up the index in the array that is being sorted and simply always keep the order but this would mean we need to use a closure when sorting with function ($tA, $tB) use ($tablesToBeSorted) . Could do it but would mean a little refactoring
tsteur
commented
Dec 2, 2016
| { | ||
| $actionType = 3; | ||
| $idSite = 1; | ||
| $select = 'log_link_visit_action.custom_dimension_1, |
There was a problem hiding this comment.
I had a similar case where it resulted in errors when executing the query depending on the PHP version
|
Glad we found this bug now rather than later 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we sort tables for join we should never "return 0" because "0" means the sort order for tables will be different depending on the PHP version (PHP5 sorting vs PHP7 sorting). I have noticed a bug where it did sort the tables completely different on PHP5 vs PHP7 and then the query crashed because wrong tables were used first.