Make sure to ignore free plugins when checking for license #10940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to https://forum.piwik.org/t/license-missing-of-a-free-glp-plugin/21674 Some users see a license warning for a free GPL plugin. I have spent hours trying to understand how this could possibly happen over the last weeks but not sure how it happens. It must be some kind of caching issue with a certain PHP version or something. This change might not fix the actual issue but is a good check to have on top to check for invalid licenses only if it is not a free plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users see a license warning for a free GPL plugin see https://forum.piwik.org/t/license-missing-of-a-free-glp-plugin/21674/6. I have spent hours trying to understand how this could possibly happen over the last weeks but not sure how it happens. It must be some kind of caching issue with a certain PHP version or something. This change might not fix the actual issue but is a good check to have on top to check for invalid licenses only if it is not a free plugin.