Add LoginLdap plugin as a submodule #10927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
the
c: Platform
sgiehl
force-pushed
the
loginldap_as_submodule
branch
from
1511853
to
3bd5051
Compare
|
rebased and updated this one. let's see if tests passes now... |
sgiehl
force-pushed
the
loginldap_as_submodule
branch
from
3bd5051
to
76388a1
Compare
sgiehl
force-pushed
the
loginldap_as_submodule
branch
from
76388a1
to
108fd1f
Compare
sgiehl
force-pushed
the
loginldap_as_submodule
branch
from
3eb90c9
to
55eb65e
Compare
|
I've update the branch and made some more change here and in LoginLdap plugin to have all tests running correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @sgiehl for making LoginLdap compatible with Piwik 3, we can now add the plugin as a submodule. This refs #10625 and may even fix the issue, as this should be the last plugin to add as submodule 馃憤