Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In DataTables to not store metric column as numbers, instead use their actual name #10916

Open
tsteur opened this issue Nov 27, 2016 · 0 comments
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.

Comments

@tsteur
Copy link
Member

tsteur commented Nov 27, 2016

  • fixes issues like http://builds-artifacts.piwik.org/piwik/plugin-Bandwidth/master/114/ where bandwidth is not available when report is flattened because Piwik applies queued filters to early and then does not know the mapping from metric id to metric name
  • makes report fetching much faster. I don't remember exact numbers but I remember numbers like 20 to 30% that were spent in many cases because metrics needed to be renamed from metric id to metric name
  • makes debugging easier as we can directly see the metric name instead of only metric ids
  • makes developing faster because we remove a lot of complexity and when having new archiver we might not be able to use IDs anymore anyway because we cannot really give IDs dynamically

Should not use too much storage because we gzip the reports anyway when storing data tables. The only "disadvantage" I can think of is that we cannot rename metrics as easily anymore (it would be currently only a change in the mapping of metric id to metric name), on the other side we could still rename metrics when applying queued filters so it shouldn't be a big issue.

@tsteur tsteur added c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Nov 27, 2016
@mattab mattab added this to the 4.0.0 milestone Dec 1, 2016
@mattab mattab removed this from the 4.0.0 milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

No branches or pull requests

3 participants