@tsteur opened this Pull Request on November 25th 2016 Member

Adding a small column to track at which position within the visit an interaction was performed. I had first added an action segment "interaction_position" so users could eg only have a look at first 3 pageviews/searches but then I noticed we need to define an action type for a segment and because this segment belongs to many types (eg pageurl and sitesearch) I cannot add it to a specific one.

I have tested it manually but couldn't really figure out how to add a test for this. Later I want to have the types configurable so people can define what they understand under "interaction" and eg include events.

ping @mattab

@mattab commented on November 29th 2016 Member

not needed for this PR but a note:

  • Whenever we display the API token in the UI, would be good to only show the first few characters and on click show the full token. this helps to let other people view the screen (from above shoulder or via screen sharing) but not leak any critical security credential
@tsteur commented on November 29th 2016 Member

Yes that's always good. On the marketplace we show the license key only after a click as well.
Maybe you meant to put this comment for the password PR?

@mattab commented on November 30th 2016 Member

@tsteur PR looks good! The easiest way to test the feature may be to add the columns in the output of the Live APIs so they will appear in our existing system tests?

@tsteur commented on November 30th 2016 Member

done we only need to update custom dimensions plugin before merging to fix test there and resolve conflict

This Pull Request was closed on November 30th 2016
Powered by GitHub Issue Mirror