New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New visit dimension "total interactions" and new action dimension "Interaction position" and corresponding segments #10911
Conversation
@@ -228,6 +228,12 @@ public function sortTablesForJoin($tA, $tB) | |||
); | |||
|
|||
if (is_array($tA) && is_array($tB)) { | |||
if (isset($tB['tableAlias']) && isset($tA['joinOn']) && strpos($tA['joinOn'], $tB['tableAlias']) !== false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix Piwik does not join correctly if 2 custom joins require each other see test
not needed for this PR but a note:
|
Yes that's always good. On the marketplace we show the license key only after a click as well. |
@tsteur PR looks good! The easiest way to test the feature may be to add the columns in the output of the Live APIs so they will appear in our existing system tests? |
Contents plugin: Rename "Interaction" metric to "Content Interaction"
done we only need to update custom dimensions plugin before merging to fix test there and resolve conflict |
Adding a small column to track at which position within the visit an interaction was performed. I had first added an action segment "interaction_position" so users could eg only have a look at first 3 pageviews/searches but then I noticed we need to define an
action type
for a segment and because this segment belongs to many types (eg pageurl and sitesearch) I cannot add it to a specific one.I have tested it manually but couldn't really figure out how to add a test for this. Later I want to have the types configurable so people can define what they understand under "interaction" and eg include events.
ping @mattab