Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New visit dimension "total interactions" and new action dimension "Interaction position" and corresponding segments #10911

Merged
merged 14 commits into from Nov 30, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 25, 2016

Adding a small column to track at which position within the visit an interaction was performed. I had first added an action segment "interaction_position" so users could eg only have a look at first 3 pageviews/searches but then I noticed we need to define an action type for a segment and because this segment belongs to many types (eg pageurl and sitesearch) I cannot add it to a specific one.

I have tested it manually but couldn't really figure out how to add a test for this. Later I want to have the types configurable so people can define what they understand under "interaction" and eg include events.

ping @mattab

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 25, 2016
@tsteur tsteur added this to the 3.0.0-b4 milestone Nov 25, 2016
@@ -228,6 +228,12 @@ public function sortTablesForJoin($tA, $tB)
);

if (is_array($tA) && is_array($tB)) {
if (isset($tB['tableAlias']) && isset($tA['joinOn']) && strpos($tA['joinOn'], $tB['tableAlias']) !== false) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix Piwik does not join correctly if 2 custom joins require each other see test

@mattab
Copy link
Member

mattab commented Nov 29, 2016

not needed for this PR but a note:

  • Whenever we display the API token in the UI, would be good to only show the first few characters and on click show the full token. this helps to let other people view the screen (from above shoulder or via screen sharing) but not leak any critical security credential

@tsteur
Copy link
Member Author

tsteur commented Nov 29, 2016

Yes that's always good. On the marketplace we show the license key only after a click as well.
Maybe you meant to put this comment for the password PR?

@mattab
Copy link
Member

mattab commented Nov 30, 2016

@tsteur PR looks good! The easiest way to test the feature may be to add the columns in the output of the Live APIs so they will appear in our existing system tests?

@tsteur
Copy link
Member Author

tsteur commented Nov 30, 2016

done we only need to update custom dimensions plugin before merging to fix test there and resolve conflict

@mattab mattab changed the title Track interaction position New visit dimension "total interactions" and new action dimension "Interaction position" and corresponding segments Nov 30, 2016
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants