Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks and events in Goals UI #10903

Merged
merged 14 commits into from Nov 27, 2016
Merged

Minor tweaks and events in Goals UI #10903

merged 14 commits into from Nov 27, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 23, 2016

This is the PR for Piwik 3 for #10844

Ideally we squash this PR please :)

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 23, 2016
@tsteur tsteur added this to the 3.0.0-b4 milestone Nov 23, 2016
@@ -319,6 +325,7 @@ var hasBlockedContent = false;
bulkFetch: bulkFetch,
post: post,
fetch: fetch,
addPostParams: addPostParams,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets plugins add post params before a request is sent

@@ -55,16 +55,18 @@ window.initializeSparklines = function () {
return;
}

var sparklines = parent.find('div.sparkline');
var sparklines = parent.find('div.sparkline:not(.notLinkable)');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature to not make some sparklines linkable. This is useful when other plugins add sparklines to eg Goal Sparklines etc.

@@ -83,6 +83,14 @@
}
});

scope.$watch('formField.uiControlAttributes.disabled', function (val, oldVal) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes a bug that select field was not updated when disabled value changed

@@ -46,15 +46,15 @@ public function createGoalsOverviewPage($goals)
$config->forceViewDataTable(Evolution::ID);
$config->setSubcategoryId($subcategory);
$config->setAction('getEvolutionGraph');
$config->setOrder(++$this->orderId);
$config->setOrder(5);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now use fixed orders. Before the order was very random for each goal. By using fixed order positions for each widget other plugins can hook into any goal page and position widgets in between

*/
public function registerEvents()
{
return array(
'AssetManager.getStylesheetFiles' => 'getStylesheetFiles',
'Request.getRenamedModuleAndAction' => 'renameProfessionalServicesModule',
'Template.afterGoalConversionOverviewReport' => 'getGoalOverviewPromo',
'Template.afterGoalConversionOverviewReport' => array('function' => 'getGoalOverviewPromo', 'after' => true),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should always show the promo at the end in case other plugins want to add content to this event

@tsteur
Copy link
Member Author

tsteur commented Nov 27, 2016

Merging for now. Let me know about any feedback and I apply changes later

@tsteur tsteur merged commit f6a67af into 3.x-dev Nov 27, 2016
@tsteur tsteur deleted the goalevents3x branch November 27, 2016 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant