Some characters in titles appear encoded #10902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #10663 `e('html_attr')` is not needed as it is a plain translation anyway
tsteur
added
Needs Review
sgiehl
reviewed
Nov 28, 2016
| @@ -10,7 +10,7 @@ | |||
| {% block content %} | |||
|
|
|||
| <div class="api-list"> | |||
| <div piwik-content-block content-title="{{ title|e('html_attr') }}" rate="true"> | |||
| <div piwik-content-block content-title="{{ title }}" rate="true"> | |||
There was a problem hiding this comment.
Wouldn't that break if the title contains a "?
There was a problem hiding this comment.
It should use the standard escaping but I haven't tried it
There was a problem hiding this comment.
Just tested it with a ". Seems to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10663
e('html_attr')is not needed as it is a plain translation anyway